increase debounce threshold for instant searches #5944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf8d5a0 to
f552116
Compare
akatsoulas
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mozilla/sumo#1717
I discovered that we're already "debouncing" changes to the instant search input box, but the pause threshold is far too low, so we're seeing too many fractured search terms in GA4. This PR increases the pause threshold from 200ms to 600ms, which should remove a lot of search-term fracturing.
Alternative
Another option would be to make our "instant" searches behave like our searches made on the search page. Those searches are only triggered once the user submits the search term via the "enter" key, so we're capturing the user's intention rather than all of the intermediate steps.